fix: Skip Azure Monitor profiler on unsupported OS#1113
Merged
Conversation
Gate AddAzureMonitorProfiler() to Windows/Linux while keeping Azure Monitor export enabled on all platforms, and log when profiler registration is skipped.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a startup failure on macOS by skipping AddAzureMonitorProfiler() registration on unsupported platforms while keeping UseAzureMonitor() enabled for cross-platform telemetry export.
Changes:
- Gate profiler registration on
OperatingSystem.IsWindows() || OperatingSystem.IsLinux(). - Track when profiler is skipped and emit a structured warning log with OS description.
- Add a new
[LoggerMessage]partial method for the warning.
BenjaminMichaelis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AddAzureMonitorProfiler() is only supported on Windows and Linux. On macOS, enabling Azure Monitor caused startup to fail with System.NotSupportedException.
What changed
Result
The app no longer fails at startup on macOS due to profiler registration, while Azure Monitor telemetry remains enabled.